fix(node-18): ATS URL Parsing #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1302 +/- ##
===========================================
+ Coverage 0 78.25% +78.25%
===========================================
Files 0 15 +15
Lines 0 1761 +1761
===========================================
+ Hits 0 1378 +1378
- Misses 0 383 +383
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
erisu
changed the title
erisu
approved these changes
Apr 9, 2023
NiklasMerz
approved these changes
Apr 11, 2023
|
Just note for people who has problem Invalid url should change to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS, with node18
Motivation and Context
Fixes #1290: currently parsing of
access,allow-navigation, andallow-intentdirectives in config.xml for Application Transport Security is broken when using node 18 due to changes to how node handles URLs.Description
Move URL parsing to the (non-deprecated) WHATWG URL API in node, and workaround the issues that cause URL parsing to fail or return unexpected results with that API.
Testing
All unit tests pass, but I would feel more confident if people tried throwing some weirder corner cases at this to ensure it's actually behaving consistently with previous versions.
Checklist