fix: Apply new Xcode flags consistently across test projects #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1343 +/- ##
==========================================
+ Coverage 78.58% 78.62% +0.03%
==========================================
Files 15 15
Lines 1770 1773 +3
==========================================
+ Hits 1391 1394 +3
Misses 379 379 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This seems to cause too many issues with various 3rd party plugins and pods, so just keep the existing behaviour for generated project files.
erisu
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
We updated the Xcode project flags for CordovaLib and the project template, but not for the test projects.
Description
Apply the same Xcode flags to the test projects to make them more closely match the generate project flags, also fix up some other warnings around selector usage and copying script steps.
Testing
Ran tests both on the CLI with
npm testand in Xcode.Checklist