Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix version checking helper scripts #1435

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented May 27, 2024

Platforms affected

iOS

Motivation and Context

Fixes GH-1415
Fixes GH-1432

Description

The bin scripts in the template needed to be updated to refer to the cordova-ios internals as a node module instead of as loose files in the same directory.

Testing

All unit tests pass.

Checklist

  • I've run the tests to see all new and existing tests pass
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

@dpogue dpogue linked an issue May 27, 2024 that may be closed by this pull request
3 tasks
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (2240ebc) to head (25185a3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1435   +/-   ##
=======================================
  Coverage   78.35%   78.35%           
=======================================
  Files          16       16           
  Lines        1825     1825           
=======================================
  Hits         1430     1430           
  Misses        395      395           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpogue dpogue added this to the 7.1.1 milestone May 28, 2024
@erisu erisu merged commit 80024fd into apache:master Jul 11, 2024
10 checks passed
@dpogue dpogue deleted the bin-fix branch August 12, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants