Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up ancient plist-to-config.xml cruft #1459

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Aug 15, 2024

Platforms affected

iOS

Motivation and Context

Closes #1414.

This was for migrating from PhoneGap 1.x to Cordova, and is definitely not compatible with any modern version of Python.

Description

Remove old Python script, and a reference in an error message to that script.

Testing

None?

This was for migrating from PhoneGap 1.x to Cordova, and is definitely
not compatible with any modern version of Python.

Closes apache#1414.
@dpogue dpogue added this to the 8.0.0 milestone Aug 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (5089892) to head (28cb000).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1459   +/-   ##
=======================================
  Coverage   78.35%   78.35%           
=======================================
  Files          16       16           
  Lines        1825     1825           
=======================================
  Hits         1430     1430           
  Misses        395      395           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpogue dpogue merged commit fb8eeab into apache:master Aug 15, 2024
10 checks passed
@dpogue dpogue deleted the bin-cleanup branch August 15, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Next Major] Delete bin/cordova_plist_to_config_xml script
4 participants