fix(Podfile): Avoid creating an empty Podfile on plugin install #1467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Closes GH-1365.
Description
Calling
new Podfile(...)
will create an empty Podfile in the project if it does not exist. If we don't have any pods to add for a given plugin, we can skip doing anything at all with the Podfile and avoid needlessly creating it.Note: I moved an
if
block to do an early return, which de-indented the majority of the code in that function. This PR is easier to review with whitespace changes disabled.Testing
Tested manually by creating a new project and installing the
cordova-plugin-inappbrowser
and confirmed that no Podfile was present in theplatforms/ios
directory.Checklist