Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error when no simulators are available #1470

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Aug 19, 2024

Platforms affected

iOS

Motivation and Context

Closes GH-526.
Closes GH-1366.
Closes GH-1377.
Closes GH-1469.

Description

Changed getDefaultSimulatorTarget() to reject with an error message when no simulators are found.

This should at least return a useful and actionable error message to the end user, rather than "Cannot read property name of undefined".

Testing

Existing unit tests pass.
Added unit test to confirm the function now rejects when no simulators are present.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

This should at least return a useful and actionable error message to the
end user, rather than "Cannot read property name of undefined".

Closes apacheGH-526.
Closes apacheGH-1366.
Closes apacheGH-1377.
Closes apacheGH-1469.
@dpogue dpogue added this to the 8.0.0 milestone Aug 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.36%. Comparing base (1aea8e7) to head (cc17e9f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1470      +/-   ##
==========================================
+ Coverage   78.35%   78.36%   +0.01%     
==========================================
  Files          16       16              
  Lines        1825     1826       +1     
==========================================
+ Hits         1430     1431       +1     
  Misses        395      395              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpogue dpogue merged commit 4f8992a into apache:master Aug 20, 2024
10 checks passed
@dpogue dpogue deleted the missing-sims-fix branch August 20, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment