IOS fix slow contact access due to photos temp file generation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Do-while test if tmp file exists" costs a lot. Use mktemp instead to generate photo tmp file. Before (300 contacts with pictures): 5minutes After: 10 seconds
khawkins
referenced
this pull request
in forcedotcom/cordova-ios
Dec 12, 2012
Updates to support iOS 6
|
Thanks! Merged in: http://git-wip-us.apache.org/repos/asf/cordova-ios/commit/c6a1dbe3 |
|
Nice ! Thanks :) |
khawkins
referenced
this pull request
in khawkins/cordova-ios
Feb 11, 2013
Updating to Cordova 2.3 final
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Do-while test if tmp file exists" costs a lot. Use mktemp instead to generate photo tmp file.
Before (300 contacts with pictures):
5minutes
After:
10 seconds
NB: I made also a pull-request on phonegap central repository : phonegap/phonegap#19
I figured out after that this repo would be the right place.