Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify installation on AppVeyor CI #383

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jul 29, 2018

Platforms affected

iOS

What does this PR do?

  • Simplify installation on AppVeyor CI now that uncrustify is gone, should now succeed on deprecated Node.js 4 version

What testing has been done on this change?

  • Check that AppVeyor CI succeeds on all Node.js versions in appveyor.yml including deprecatd Node.js version

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

codecov-io commented Jul 29, 2018

Codecov Report

Merging #383 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   63.86%   63.86%           
=======================================
  Files          14       14           
  Lines        1702     1702           
  Branches      286      286           
=======================================
  Hits         1087     1087           
  Misses        615      615

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff9bca...e3d3a4d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants