WIP: major eslint updates (with eslint-config-standard@next) for evaluation only

[brodycj]

Platforms affected

iOS

What does this PR do?

WIP for evaluation & discussion only (with an alt-wip branch name):

• major eslint updates, using eslint-config-standard@next (^12.0.0-alpha.0) as needed to resolve [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning (Release 12.0.0 standard/eslint-config-standard#123 (comment)) when using eslint@5, taken from PR WIP - update dev deps (with additional TODO list) #382

cannot be backported to 4.5.x since it requires minimum Node.js 6

Alternative using eslint@4, not using alpha eslint-config-standard@next version, is in #389.

What testing has been done on this change?

• check that npm test items pass on Travis CI

Checklist

• Reported an issue in the JIRA database
• Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
• Added automated test coverage as appropriate for this change.

[codecov-io]

Codecov Report

Merging #390 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #390   +/-   ##
=======================================
  Coverage   65.62%   65.62%           
=======================================
  Files          14       14           
  Lines        1702     1702           
  Branches      286      286           
=======================================
  Hits         1117     1117           
  Misses        585      585

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f628f61...b6f3da6. Read the comment docs.

[erisu]

Is there a reason that this one has to be on @next?
Could it be eslint-config-standard@^11.0.0 as seen in the other evaluation PR #389 while the rest were updated?

I don't see any problems with updating all of them. I prefer this PR. (+1)

[brodycj]

eslint-config-standard@next was needed to resolve an ugly warning message from eslint@5, details are now in the description

[brodycj]

FYI ^12.0.0-alpha.0 means that we would use the -alpha version until the publish a newer version, such as -beta, or finally publish 12.0.0 version

[brodycj]

To clarify the general question: I would generally favor upgrading to "latest" version of dependencies and devDependencies whenever possible when targeting upcoming major release. The problem is that using eslint@latest would lead to the ugly warning as discussed in the updated description and review comments unless we would use eslint-config-standard@next (eslint-config-standard@^12.0.0-alpha.0). We are basically stuck waiting for [email protected] to be released as discussed in standard/eslint-config-standard#123.

I think we should not introduce "@next" dependency version unless absolutely necessary for some reason.

[shazron]

Is this still WIP? There are conflicts that need to be resolved.

[erisu]

Closing in favor #496 which is now merged.