Added Back Missing unorm Dependency #406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
ios
What does this PR do?
The goal of this PR is to re-add the missing dependency so cordova-ios does not fail with cordova-common master.
cordova-common use to have a dependency called unorm. This dependency was not being used in cordova-common so I suspect it was removed.
apache/cordova-common@d473b19#diff-b9cfc7f2cdf78a7f4b91a753d10865a2
This dependency, on the other hand, was being used in cordova-ios.
cordova-ios/bin/templates/scripts/cordova/Api.js
Line 24 in ff1bcd0
cordova-ios/bin/templates/scripts/cordova/lib/prepare.js
Line 26 in ff1bcd0
Previously, unorm use to to be a committed node_module for cordova-ios repo. Once the committed node_modules were removed, both cordova-ios and cordova-common on the master branch were missing this dependency.
If you clone cordova-ios master, run npm install, and then run the tests for ios, it does not fail is because cordova-ios package.json is configured to use [email protected] which has unorm. To reproduce, make sure to also update cordova-common to point to master.
What testing has been done on this change?
npm run
Test failures may appear when running against cordova-common@master. This is not related to adding unorm. I had also tested using the older version of [email protected], which is identical to what has been committed into the repo previously.
Those issues will need to be invested and fixed in a separate PR.