-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-407: remove removing certificates functions in xcode post scripts #508
GH-407: remove removing certificates functions in xcode post scripts #508
Conversation
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
=======================================
Coverage 74.75% 74.75%
=======================================
Files 11 11
Lines 1822 1822
=======================================
Hits 1362 1362
Misses 460 460 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just ran an export in Xcode 10 (in the Xcode app) with these changes and automatic provisioning and it worked! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice, how will I know as soon as the next release contains this? |
Note: This also resolves CB-14264 |
@jpike88 You can follow releases of repositories on Github (leftmost button at the top, next to "Star" and "Fork"), there will also be a blog post at blog.cordova.io. |
Platforms affected
ios
What does this PR do?
To fix #407 with automatic provioning.
This PR fixs the issue that
ios-deploy
(cordova run --device
) can not work with automatic provisoning.This PR simply remove following lines
in cordova/lib/copy-www-build-step.js.
I am not sure why that codes are here.
But I image that the old version of the cordova use
xcrun
for the certification after building process. In such situation, the above codes are necessary.However I found that these codes lead strange behavior with automatic provisioning in ios-deploy (in
cordova run --device
) as reported in #407 .What testing has been done on this change?
I test as following on my local mac (mojave).
cordova run --device
with automatic provisioning using Xcode 10.1.cordova run --device
with manual provioning using Xcode 10.1.cordova run --device
with automatic provisioning using Xcode 9.4.1.cordova run --device
with manual provioning using Xcode 9.4.1.All they works well.