Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint everything #710

Merged
merged 4 commits into from
Nov 7, 2019
Merged

Lint everything #710

merged 4 commits into from
Nov 7, 2019

Conversation

raphinesse
Copy link
Contributor

  • Ensure to lint as many files as possible
    • Binaries w/out file extension and cordova-js-src/* hadn't been linted before
  • Apply fixes where necessary

Fixes #633

@raphinesse raphinesse added this to the 5.0.2 milestone Nov 6, 2019
@codecov-io
Copy link

Codecov Report

Merging #710 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #710   +/-   ##
=======================================
  Coverage   74.08%   74.08%           
=======================================
  Files          11       11           
  Lines        1829     1829           
=======================================
  Hits         1355     1355           
  Misses        474      474

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61a172c...95df93c. Read the comment docs.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raphinesse raphinesse merged commit 2d3fb87 into apache:master Nov 7, 2019
@raphinesse raphinesse deleted the lint-everything branch November 7, 2019 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaScript files w/out file ending are not linted
3 participants