Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14135(ios): escape all single quotes from name in Podfile #731

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

jcesarmobile
Copy link
Member

Motivation and Context

If the app name have multiple single quotes the Podfile is not correctly generated

Description

make the escape function to escape all occurrences and not just the first one

Testing

added a new test

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcesarmobile jcesarmobile merged commit c1a6640 into apache:master Dec 2, 2019
@jcesarmobile jcesarmobile deleted the CB-14135 branch December 2, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants