Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump node requirement (>=10) #743

Merged
merged 1 commit into from
Dec 17, 2019
Merged

chore: bump node requirement (>=10) #743

merged 1 commit into from
Dec 17, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Dec 17, 2019

Motivation and Context

Description

  • Bump engines.node to >=10 in package.json
  • Drop node 6 and 8 from CI services.

Testing

  • npm t
  • CI services continue to pass

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone Dec 17, 2019
@codecov-io
Copy link

codecov-io commented Dec 17, 2019 •
edited
Loading

Codecov Report

Merging #743 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #743   +/-   ##
=======================================
  Coverage   74.26%   74.26%           
=======================================
  Files          11       11           
  Lines        1846     1846           
=======================================
  Hits         1371     1371           
  Misses        475      475

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1a6640...e0019d0. Read the comment docs.

@erisu erisu mentioned this pull request Dec 17, 2019
Merged
1 task
jcesarmobile
jcesarmobile approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@erisu erisu merged commit 076edd0 into apache:master Dec 17, 2019
@erisu erisu deleted the v6-drop-old-node-support branch December 17, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbru31 timbru31 timbru31 approved these changes

@jcesarmobile jcesarmobile jcesarmobile approved these changes

@dpogue dpogue Awaiting requested review from dpogue

@raphinesse raphinesse Awaiting requested review from raphinesse

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@erisu @codecov-io @timbru31 @jcesarmobile