-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use arrow functions #747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I flagged a few things that I would like to see changed.
2a79ae5
to
08aa0f4
Compare
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
==========================================
+ Coverage 74.29% 74.32% +0.02%
==========================================
Files 11 11
Lines 1852 1842 -10
==========================================
- Hits 1376 1369 -7
+ Misses 476 473 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now 👍
I've took the liberty to resolve the minor merge conflicts via the GitHub UI. |
Thank you for fixing the merge conflicts @timbru31 |
Motivation and Context
Modernize code
Description
lebab
to apply--transform arrow
and--transform arrow-return
.arrow-return
for readability.Testing
npm t