Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: remove MediaPlaybackRequiresUserAction and update MediaTypesRequiringUserActionForPlayback to proper variable types #797

Merged
merged 2 commits into from
Feb 27, 2020
Merged

breaking: remove MediaPlaybackRequiresUserAction and update MediaTypesRequiringUserActionForPlayback to proper variable types #797

merged 2 commits into from
Feb 27, 2020

Commits on Feb 25, 2020

  1. fix (MediaTypesRequiringUserActionForPlayback): pass valid media type

    @erisu
    erisu committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    5792c8a View commit details
    Browse the repository at this point in the history

  2. breaking (MediaPlaybackRequiresUserAction): delete 

    * As the new preference key always exists in "defaults.xml", the old preference key would never be used.
* Updated deprecation warning logic to include "has been" deprecated since it was completely removed. Most cases the warning would be removed as well but the previous releases never properly warn the user. Warning will remain for next major only as a migration step for users.
    @erisu
    erisu committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    cb8f965 View commit details
    Browse the repository at this point in the history