-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: replace shelljs with fs-extra #851
breaking: replace shelljs with fs-extra #851
Conversation
a55f605
to
0d98b03
Compare
Codecov Report
@@ Coverage Diff @@
## master #851 +/- ##
==========================================
- Coverage 74.85% 74.76% -0.09%
==========================================
Files 13 13
Lines 1742 1736 -6
==========================================
- Hits 1304 1298 -6
Misses 438 438
Continue to review full report at Codecov.
|
* Replace pgrep command with find-process * Replace shell.exec with superspawn.spawn
* Added missing defaults.xml test fixture file
0447780
to
b9b99fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation, Context & Description
shelljs
dependency forfs-extra
.Testing
npm t
Checklist