-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PreferredContentMode preference #886
Conversation
Codecov Report
@@ Coverage Diff @@
## master #886 +/- ##
==========================================
+ Coverage 74.40% 76.30% +1.89%
==========================================
Files 13 13
Lines 1676 1941 +265
==========================================
+ Hits 1247 1481 +234
- Misses 429 460 +31
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewEngine.m
Outdated
Show resolved
Hide resolved
CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewEngine.m
Outdated
Show resolved
Hide resolved
Co-authored-by: エリス <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Platforms affected
iOS
Motivation and Context
This adds a prefrence to the webview which is useful for iPads. Apple introduced a setting which by defaults changes the useragent of iPads from
iPad
toMacintosh
to provide a "desktop browsing experience". The new preference allows to change the default value.See original issue from IAB: apache/cordova-plugin-inappbrowser#687
Description
Changed like : apache/cordova-plugin-inappbrowser#688
Documenation: apache/cordova-docs#1083
Testing
Automatic tests still pass. I found no automatic tests for preferences at build time.
I created a blank new app, added this platform and checked
navigator.userAgent
while changing the preference. It should beiPad
formobile
andMacintosh
fordesktop
.Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)