CB-9189 android: Implementing save/restore API to handle Activity destruction #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased to master and update the README link. Sorry, I lost track of this over the holidays. I plan to merge this in at end of day. @jasongin can you give this a quick look? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the long standing issue of the camera plugin crashing after receiving an Activity result when the Cordova Activity is killed in the background (CB-9189). Uses the new API for plugin save/restore that was merged into cordova-android recently.
NOTE: The link I put in the README is for Android docs that have been merged in to dev, but not published yet. It'll work once we do a docs release. Right now it's broken.