Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documenting the custom schemes handling #357

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

documenting the custom schemes handling #357

wants to merge 2 commits into from

Conversation

boynet
Copy link

@boynet boynet commented Nov 28, 2018 •
edited
Loading

Platforms affected

android, ios

What does this PR do?

documenting the custom schemes handling(#263 and #274)

need to wait for #274 to get merged

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

janpio
janpio reviewed Nov 28, 2018
View reviewed changes
README.md Outdated Show resolved Hide resolved
@janpio @boynet
typo
bac3dc1 
Co-Authored-By: boynet <[email protected]>
@boynet
Copy link
Author

boynet commented Nov 28, 2018

some things I am not sure about:

  • should the preference part move into the Installation step?
  • should I give real world example like facebook\twitter\whatsapp or keep the "examplescheme"
  • the ios pr CB-14187: (ios) Change the InAppBrowser to allow custom schemes #274 not merged yet so we need for it to get merged in order to accept this, or just state that its for android only

@janpio
Copy link
Member

janpio commented Nov 28, 2018

Best let's wait that #274 gets merged. (Mention it in the description of the PR)

@brodycj brodycj mentioned this pull request Dec 30, 2019
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio left review comments

Assignees
No one assigned
Labels
platform: android platform: ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boynet @janpio