[GH-652] add check for openInSystem postNotification #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks for your PR. Code wise it looks good. I'll test your branch later today. |
klima
approved these changes
Mar 30, 2020
astanecki
approved these changes
Mar 30, 2020
expertanswerz
pushed a commit
to expertanswerz/cordova-plugin-inappbrowser
that referenced
this pull request
Apr 9, 2020
* master: docs: replaces outdated transition and presentation style links (apache#662) chore: remove deprecated orientation methods (apache#666) Fix incorrect TypeScript typings (apache#515) [apacheGH-652] add check for openInSystem postNotification (apache#654) ci: updates Node.js versions (apache#659) chore(npm): improve ignore list (apache#658) fix(android): Reset lefttoright if not set (apache#442) [android] Correcting the documentation regarding lefttoright opt… (apache#648) (android) Added option to turn on/off fullscreen mode in Android (apache#634) Android apacheGH-470 InAppBrowser: java.lang.IllegalArgumentException (apache#616) breaking(ios): remove UIWebView (apache#635) chore(release): 3.2.1-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
fixes #652
This fix prevents window.handleOpenURL from being triggered by calls to _system browser through InAppBrowser which was previously fixed in UIWebView version of IAB but still exists in WKWebView version
Description
Add
if ([[UIApplication sharedApplication] openURL:url] == NO)check in openInSystem method which was present in UIWebView version of IAB but not WKWebView.Testing
Ran plugintests repo
Manually tested in my own project where I first noticed the issue
Manually tested in minimum reproduction repo and pushed to a branch
Checklist
(platform)if this change only applies to one platform (e.g.(android))