refactor(eslint): use cordova-eslint /w fix (#179)

.eslintrc.yml

@@ -1,10 +1,23 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 root: true
-extends: semistandard
-rules:
-  indent:
-    - error
-    - 4
-  camelcase: off
-  padded-blocks: off
-  operator-linebreak: off
-  no-throw-literal: off
+extends: "@cordova/eslint-config/browser"
+
+overrides:
+  - files: [tests/**/*.js]
+    extends: "@cordova/eslint-config/node-tests"

package.json

@@ -24,8 +24,8 @@
     "cordova-windows"
   ],
   "scripts": {
-    "test": "npm run eslint",
-    "eslint": "eslint www && eslint src && eslint tests"
+    "test": "npm run lint",
+    "lint": "eslint ."
   },
   "author": "Apache Software Foundation",
   "license": "Apache-2.0",
@@ -43,12 +43,6 @@
     }
   },
   "devDependencies": {
-    "eslint": "^4.0.0",
-    "eslint-config-semistandard": "^11.0.0",
-    "eslint-config-standard": "^10.2.1",
-    "eslint-plugin-import": "^2.3.0",
-    "eslint-plugin-node": "^5.0.0",
-    "eslint-plugin-promise": "^3.5.0",
-    "eslint-plugin-standard": "^3.0.1"
+    "@cordova/eslint-config": "^3.0.0"
   }
 }

src/browser/CaptureProxy.js

@@ -17,9 +17,7 @@
  * specific language governing permissions and limitations
  * under the License.
  *
-*/
-
-/* global require, module */
+ */
 
 var MediaFile = require('cordova-plugin-media-capture.MediaFile');
 var MediaFileData = require('cordova-plugin-media-capture.MediaFileData');
@@ -54,18 +52,18 @@ function dataURItoBlob (dataURI) {
  * Capture starts, when you clicking on preview.
  */
 function CameraUI () {
-
     // Root element for preview
     var container = document.createElement('div');
-    container.style.cssText = 'left: 0px; top: 0px; width: 100%; height: 100%; position: fixed; z-index:9999;' +
-                                   'padding: 40px; background-color: rgba(0,0,0,0.75);' +
-                                   'text-align:center; visibility: hidden';
+    container.style.cssText =
+        'left: 0px; top: 0px; width: 100%; height: 100%; position: fixed; z-index:9999;' +
+        'padding: 40px; background-color: rgba(0,0,0,0.75);' +
+        'text-align:center; visibility: hidden';
 
     // Set up root element contetnts
     container.innerHTML =
         '<div id="captureHint" style="height:100%; position:relative; display:inline-flex; align-content:flex-start;">' +
         '<h2 style="position: absolute; width: 100%; background-color: rgba(255,255,255,0.25); margin: 0">' +
-            'Click on preview to capture image. Click outside of preview to cancel.</h1>' +
+        'Click on preview to capture image. Click outside of preview to cancel.</h1>' +
         '<video id="capturePreview" style="height: 100%"></video>' +
         '</div>';
 
@@ -114,15 +112,19 @@ CameraUI.prototype.startPreview = function (count, successCB, errorCB) {
         errorCB(new CaptureError(CaptureError.CAPTURE_NO_MEDIA_FILES));
     };
 
-    navigator.getUserMedia({video: true}, function (previewStream) {
-        // Save video stream to be able to stop it later
-        that._previewStream = previewStream;
-        that.preview.src = URL.createObjectURL(previewStream); // eslint-disable-line no-undef
-        // We don't need to set visibility = true for preview element
-        // since this will be done automatically in onplay event handler
-    }, function (/* err */) {
-        errorCB(new CaptureError(CaptureError.CAPTURE_INTERNAL_ERR));
-    });
+    navigator.getUserMedia(
+        { video: true },
+        function (previewStream) {
+            // Save video stream to be able to stop it later
+            that._previewStream = previewStream;
+            that.preview.src = URL.createObjectURL(previewStream); // eslint-disable-line no-undef
+            // We don't need to set visibility = true for preview element
+            // since this will be done automatically in onplay event handler
+        },
+        function (/* err */) {
+            errorCB(new CaptureError(CaptureError.CAPTURE_INTERNAL_ERR));
+        }
+    );
 };
 
 /**
@@ -152,7 +154,6 @@ module.exports = {
     },
 
     captureImage: function (successCallback, errorCallback, args) {
-
         var fail = function (code) {
             if (errorCallback) {
                 errorCallback(new CaptureError(code || CaptureError.CAPTURE_INTERNAL_ERR));
@@ -170,56 +171,69 @@ module.exports = {
         // Counter for already taken images
         var imagesTaken = 0;
 
-        navigator.getUserMedia = navigator.getUserMedia ||
-                         navigator.webkitGetUserMedia ||
-                         navigator.mozGetUserMedia ||
-                         navigator.msGetUserMedia;
+        navigator.getUserMedia =
+            navigator.getUserMedia || navigator.webkitGetUserMedia || navigator.mozGetUserMedia || navigator.msGetUserMedia;
 
         if (!navigator.getUserMedia) {
             fail(CaptureError.CAPTURE_NOT_SUPPORTED);
             return;
         }
 
         var ui = new CameraUI();
-        ui.startPreview(limit, function (data) {
-            // Check if we're done with capture. If so, then destroy UI
-            if (++imagesTaken >= limit) {
+        ui.startPreview(
+            limit,
+            function (data) {
+                // Check if we're done with capture. If so, then destroy UI
+                if (++imagesTaken >= limit) {
+                    ui.destroyPreview();
+                }
+
+                // Array of resultant MediaFiles
+                var mediaFiles = [];
+
+                // save data to file here
+                window.requestFileSystem(
+                    window.TEMPORARY,
+                    data.length * limit,
+                    function (fileSystem) {
+                        // If we need to capture multiple files, then append counter to filename
+                        var fileName = limit <= 1 ? 'image.jpg' : 'image' + imagesTaken + '.jpg';
+                        fileSystem.root.getFile(
+                            fileName,
+                            { create: true },
+                            function (file) {
+                                file.createWriter(function (writer) {
+                                    writer.onwriteend = function () {
+                                        file.getMetadata(function (meta) {
+                                            mediaFiles.push(
+                                                new MediaFile(file.name, file.toURL(), 'image/jpeg', meta.modificationTime, meta.size)
+                                            );
+                                            // Check if we're done with capture. If so, then call a successCallback
+                                            if (imagesTaken >= limit) {
+                                                successCallback(mediaFiles);
+                                            }
+                                        }, fail);
+                                    };
+                                    writer.onerror = fail;
+                                    // Since success callback for start preview returns
+                                    // a base64 encoded string, we need to convert it to blob first
+                                    writer.write(dataURItoBlob(data));
+                                });
+                            },
+                            fail
+                        );
+                    },
+                    fail
+                );
+            },
+            function (err) {
                 ui.destroyPreview();
+                fail(err.code);
             }
-
-            // Array of resultant MediaFiles
-            var mediaFiles = [];
-
-            // save data to file here
-            window.requestFileSystem(window.TEMPORARY, data.length * limit, function (fileSystem) {
-                // If we need to capture multiple files, then append counter to filename
-                var fileName = limit <= 1 ? 'image.jpg' : 'image' + imagesTaken + '.jpg';
-                fileSystem.root.getFile(fileName, {create: true}, function (file) {
-                    file.createWriter(function (writer) {
-                        writer.onwriteend = function () {
-                            file.getMetadata(function (meta) {
-                                mediaFiles.push(new MediaFile(file.name, file.toURL(), 'image/jpeg', meta.modificationTime, meta.size));
-                                // Check if we're done with capture. If so, then call a successCallback
-                                if (imagesTaken >= limit) {
-                                    successCallback(mediaFiles);
-                                }
-                            }, fail);
-                        };
-                        writer.onerror = fail;
-                        // Since success callback for start preview returns
-                        // a base64 encoded string, we need to convert it to blob first
-                        writer.write(dataURItoBlob(data));
-                    });
-                }, fail);
-            }, fail);
-        }, function (err) {
-            ui.destroyPreview();
-            fail(err.code);
-        });
+        );
     },
 
     getFormatData: function (successCallback, errorCallback, args) {
-
         var img = document.createElement('img');
         img.src = args[0];
         img.onload = function () {