Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(ios): remove code warnings #177

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

jcesarmobile
Copy link
Member

Breaking because removes old ios 6-7-8-9 code.

Replaces UIAlertView deprecated on iOS 8 with UIAlertController
add missing self
removes ios < 6 code
replaces deprecated openURL with the newer one with more params
removes deprecated setStatusBarStyle methods
removes deprecated - (NSUInteger)supportedInterfaceOrientations methods

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jcesarmobile jcesarmobile merged commit 09bc0b1 into apache:master Aug 25, 2020
@jcesarmobile jcesarmobile deleted the fix-warning branch August 25, 2020 22:46
pinionpi added a commit to pinionpi/cordova-plugin-media-capture-mp4video that referenced this pull request Oct 19, 2021
* origin-apache/master: (91 commits)
  ci(ios): update workflow w/ iOS 15 (apache#231)
  ci: add action-badge (apache#230)
  ci: remove travis & appveyor (apache#229)
  ci: add gh-actions workflows (apache#228)
  fix(android): remove unknown permission android.permission.RECORD_VIDEO (apache#200)
  ci: add node-14.x to workflow (apache#203)
  chore: clean up package.json (apache#193)
  ci(travis): update osx xcode image (apache#189)
  breaking(ios): remove code warnings (apache#177)
  ci(travis): updates Android API level (apache#188)
  chore: adds package-lock file (apache#180)
  refactor(eslint): use cordova-eslint /w fix (apache#179)
  chore(npm): use short notation in package.json (apache#178)
  chore(asf): update git notification settings
  Update CONTRIBUTING.md
  ci: updates Node.js versions (apache#165)
  chore(npm): improve ignore list (apache#164)
  Small javadoc fix (apache#161)
  ci(travis): upgrade to node 8
  chore(release): 3.0.4-dev
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants