snowflake: fix rendering of SELECT TOP #1070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Snowflake,
SELECT TOP
only supports an unparenthesized integer constant as its operand. This syntax was being parsed successfully but theDisplay
impl was rendering MSSQL style (i.e. with parentheses), which causes the resultant queries to fail in Snowflake. I fixed this by distinguishing the two different syntactic forms forTOP
in the AST.