-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SQLite column definitions with no type #1075
Conversation
Pull Request Test Coverage Report for Build 7378944390Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @takluyver -- this is looking good to me. I think @tobyhede has a good style suggestion and it would be really helpful to improve the doc comments before we merged
Should the generic dialect also support it? The docs suggest that it's 'permissive', but I wasn't sure if this would be stretching the point too far.
I don't have a strong opinion. We can maybe start with SQLite only and then expand coverage for generic dialect if people want it
Thanks both! I've renamed the helper message and tried to document this feature better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- thank you very much @takluyver (and happy new year 🎉 )
Thanks! Happy new year to you 🎆 |
SQLite allows columns with no type information:
As far as I know, other SQL databases all expect a data type for each column. So for now I've allowed this only for the SQLite dialect. Should the generic dialect also support it? The docs suggest that it's 'permissive', but I wasn't sure if this would be stretching the point too far. 🙂
Closes #743