Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for constraint characteristics clause #1099

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

dimfeld
Copy link
Contributor

@dimfeld dimfeld commented Jan 17, 2024

This adds support for [[NOT] DEFERRABLE] [INITIALLY DEFERRED | INITIALLY IMMEDIATE] [[NOT] ENFORCED] on constraint clauses.

Syntax references:

@coveralls
Copy link

coveralls commented Jan 18, 2024

Pull Request Test Coverage Report for Build 7633270040

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 87.65%

Totals Coverage Status
Change from base Build 7632579793: 0.06%
Covered Lines: 19397
Relevant Lines: 22130

💛 - Coveralls

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this contribution. I have just one request to not modify the existing tests (but instead to add a new test).

I plan to make a release later this week, for your planning purposes.

tests/sqlparser_common.rs Outdated Show resolved Hide resolved
@alamb alamb changed the title support constraint characteristics clause Add support for constraint characteristics clause Jan 23, 2024
@dimfeld
Copy link
Contributor Author

dimfeld commented Jan 23, 2024

Updated. Thanks for the feedback!

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks for the quick turnaround @dimfeld

@alamb alamb merged commit c86508b into apache:main Jan 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants