Skip to content

Commit

Permalink
Improve documentation for calculate_prune_length method in `Symmetric…
Browse files Browse the repository at this point in the history
…HashJoin` (#8125)

* Minor: Improve the document format of JoinHashMap

* Minor: Improve documentation for calculate_prune_length method

* fix: method describe
  • Loading branch information
Asura7969 authored Nov 11, 2023
1 parent bd4b3f4 commit 21b9626
Showing 1 changed file with 3 additions and 13 deletions.
16 changes: 3 additions & 13 deletions datafusion/physical-plan/src/joins/symmetric_hash_join.rs
Original file line number Diff line number Diff line change
Expand Up @@ -952,27 +952,17 @@ impl OneSideHashJoiner {
Ok(())
}

/// Prunes the internal buffer.
///
/// Argument `probe_batch` is used to update the intervals of the sorted
/// filter expressions. The updated build interval determines the new length
/// of the build side. If there are rows to prune, they are removed from the
/// internal buffer.
/// Calculate prune length.
///
/// # Arguments
///
/// * `schema` - The schema of the final output record batch
/// * `probe_batch` - Incoming RecordBatch of the probe side.
/// * `build_side_sorted_filter_expr` - Build side mutable sorted filter expression..
/// * `probe_side_sorted_filter_expr` - Probe side mutable sorted filter expression.
/// * `join_type` - The type of join (e.g. inner, left, right, etc.).
/// * `column_indices` - A vector of column indices that specifies which columns from the
/// build side should be included in the output.
/// * `graph` - A mutable reference to the physical expression graph.
///
/// # Returns
///
/// If there are rows to prune, returns the pruned build side record batch wrapped in an `Ok` variant.
/// Otherwise, returns `Ok(None)`.
/// A Result object that contains the pruning length.
pub(crate) fn calculate_prune_length_with_probe_batch(
&mut self,
build_side_sorted_filter_expr: &mut SortedFilterExpr,
Expand Down

0 comments on commit 21b9626

Please sign in to comment.