Skip to content

Commit

Permalink
Add metadata_load_time metric
Browse files Browse the repository at this point in the history
  • Loading branch information
progval committed Sep 23, 2024
1 parent 601896f commit 2b4a342
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ pub struct ParquetFileMetrics {
pub page_index_rows_matched: Count,
/// Total time spent evaluating parquet page index filters
pub page_index_eval_time: Time,
/// Total time spent reading and parsing metadata from the footer
pub metadata_load_time: Time,
}

impl ParquetFileMetrics {
Expand Down Expand Up @@ -116,6 +118,10 @@ impl ParquetFileMetrics {
.with_new_label("filename", filename.to_string())
.subset_time("page_index_eval_time", partition);

let metadata_load_time = MetricBuilder::new(metrics)
.with_new_label("filename", filename.to_string())
.subset_time("metadata_load_time", partition);

Self {
predicate_evaluation_errors,
row_groups_matched_bloom_filter,
Expand All @@ -131,6 +137,7 @@ impl ParquetFileMetrics {
statistics_eval_time,
bloom_filter_eval_time,
page_index_eval_time,
metadata_load_time,
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ impl FileOpener for ParquetOpener {
Ok(Box::pin(async move {
let options = ArrowReaderOptions::new().with_page_index(enable_page_index);

let mut metadata_timer = file_metrics.metadata_load_time.timer();
let metadata =
ArrowReaderMetadata::load_async(&mut reader, options.clone()).await?;
let mut schema = metadata.schema().clone();
Expand All @@ -133,6 +134,8 @@ impl FileOpener for ParquetOpener {
let metadata =
ArrowReaderMetadata::try_new(metadata.metadata().clone(), options)?;

metadata_timer.stop();

let mut builder =
ParquetRecordBatchStreamBuilder::new_with_metadata(reader, metadata);

Expand Down

0 comments on commit 2b4a342

Please sign in to comment.