Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming UserDefinedSQLPlanner to ExprPlanner #11304

Closed
Tracked by #11207
alamb opened this issue Jul 6, 2024 · 2 comments · Fixed by #11338
Closed
Tracked by #11207

Consider renaming UserDefinedSQLPlanner to ExprPlanner #11304

alamb opened this issue Jul 6, 2024 · 2 comments · Fixed by #11338
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jul 6, 2024

Is your feature request related to a problem or challenge?

@samuelcolvin notes on #11207 #11207 (comment)

Given how much UserDefinedSQLPlanner is being used for existing stuff within datafusion, perhaps it should be called just SQLPlanner or CustomSQLPlanner?

Since we haven't released this API yet, the name could be changed in the next few days before #11077 without causing too much downstream churn.

Describe the solution you'd like

I recommend renaming it to ExprPlanner as it is being used to plan specific exprs which seems good #11207 (comment)

Describe alternatives you've considered

No response

Additional context

No response

@andygrove
Copy link
Member

@alamb @samuelcolvin This seems to be the only issue blocking the release. Is anyone planning on working on this? If not, I'll pick it up.

@samuelcolvin
Copy link
Contributor

Please do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants