Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename UserDefinedSQLPlanner to ExprPlanner #11338

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Jul 8, 2024

Which issue does this PR close?

Closes #11304

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions core Core DataFusion crate labels Jul 8, 2024
@andygrove
Copy link
Member Author

@alamb @samuelcolvin fyi

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @andygrove

I merged up from main and also fixed a clippy error to try and help get this PR mergeable

@alamb
Copy link
Contributor

alamb commented Jul 8, 2024

merging up to resolve a conflict...

Copy link
Contributor

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you so much.

@alamb alamb merged commit 782df39 into apache:main Jul 8, 2024
23 checks passed
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
* rename UserDefinedSQLPlanner to ExprPlanner

* Clippy

---------

Co-authored-by: Andrew Lamb <[email protected]>
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jul 18, 2024
* rename UserDefinedSQLPlanner to ExprPlanner

* Clippy

---------

Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider renaming UserDefinedSQLPlanner to ExprPlanner
3 participants