Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TPCH tooling to create a combined result for easier processing by outside tools #4127

Closed
isidentical opened this issue Nov 7, 2022 · 0 comments · Fixed by #4128
Closed
Labels
enhancement New feature or request

Comments

@isidentical
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently, we have to run each query individually for retrieving the benchmark results for it. This also applies to the results, where we have to actually create multiple files and then combine them later into a single one (summaries).

$ ./tpch benchmark datafusion --query 1 -o queries
$ ./tpch benchmark datafusion --query 2 -o queries
...

Describe the solution you'd like
If --query argument is not passed, I think we should be able to run everything at once and output a uniform summary.

Describe alternatives you've considered
Automating this with an external script might also be an option, but I think this version is cleaner.

Additional context
This should ideally also help on the path to a conbench task for TPCH, since we can now get a uniform result set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant