-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combined TPCH runs & uniformed summaries for benchmarks #4128
Conversation
5fdc4a8
to
eb12555
Compare
While playing with this, I've also written a little Python script to function like a benchmark comparison UI (poor man's conbench): https://gist.github.com/isidentical/4e3fff1350e9d49672e15d54d9e8299f It is quite basic, but I think it can automate a few stuff for https://github.com/datafusion-contrib/benchmark-automation/tree/main. E.g. an example comparison between (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @isidentical !
I don't know how much you want to test the benchmark run code (it might be easier to just deal with any breakages than trying to prevent regressions through tests)
println!("Running benchmarks with the following options: {:?}", opt); | ||
let mut benchmark_run = BenchmarkRun::new(opt.query); | ||
let query_range = match opt.query { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Yeah, I tried to take a look at it but it seems like it would take a bit too much effort for a relatively simple feature. I guess we'll probably notice if something got broken when we have an automated benchmark system 😄 |
Benchmark runs are scheduled for baseline = b58ec81 and contender = a32fb65. a32fb65 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #4127.
Rationale for this change
This PR adds support for executing TPCH benchmarks without a
--query
. When there is no--query
, all the queries (from 1 to 22) is executed and the execution information regarding them are saved.tpch --query=1
tpch
Are there any user-facing changes?
The TPCH benchmark output format is different now.