Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move protoc generation to binary crate #5718

Closed
tustvold opened this issue Mar 24, 2023 · 0 comments · Fixed by #5742
Closed

Move protoc generation to binary crate #5718

tustvold opened this issue Mar 24, 2023 · 0 comments · Fixed by #5742
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge?

As of #3950 DataFusion vendors the generated protobuf code, for a variety of reasons linked to from the PR. Unfortunately in order to avoid drift this needs to pin the version of tonic-build, etc... used to generate the code. The current approach of using a build.rs causes this to leak into downstreams

Describe the solution you'd like

Move the protoc generation into a non-published subcrate as was recently done in arrow-rs - apache/arrow-rs#3927

Describe alternatives you've considered

No response

Additional context

No response
@tustvold tustvold added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Mar 24, 2023
@tustvold tustvold mentioned this issue Mar 24, 2023
Merged
l0kr added a commit to l0kr/arrow-datafusion that referenced this issue Mar 26, 2023
@l0kr
Move protoc generation to binary crate (apache#5718)
47b1721
@l0kr l0kr mentioned this issue Mar 26, 2023
Merged
alamb pushed a commit that referenced this issue Mar 27, 2023
@l0kr
Move protoc generation to binary crate (#5718) (#5742)
dda2c20 
* Move protoc generation to binary crate (#5718)

* Update license in Cargo.toml

* Generate proto in CI

* Make regen.sh executable by CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move protoc generation to binary crate (#5718) l0kr/arrow-datafusion
1 participant
@tustvold