Deprecate LogicalPlan::head_output_expr
#10024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Apr 10, 2024
| | LogicalPlan::DescribeTable(_) | ||
| | LogicalPlan::Unnest(_) => Ok(None), | ||
| } | ||
| let mut output = None; |
There was a problem hiding this comment.
I am a big fan of the treenode API
|
I think clippy found a few users of the deprecated API. Might be worth to at least migrate the DF-internal users right away. |
|
I didn't realize the function was actually used. I'll look into simply using the TreeNode API instead, rather than deprecating it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #8913
Rationale for this change
LogicalPlan::head_output_expris unused, untested and redundant now that we have #8913What changes are included in this PR?
LogicalPlan::head_output_exprAre these changes tested?
Are there any user-facing changes?