Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AggregateFunctionDefinition::Name #10441

Merged

Conversation

lewiszlw
Copy link
Member

Which issue does this PR close?

Remove AggregateFunctionDefinition::Name as it's useless.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions optimizer Optimizer rules core Core DataFusion crate substrait labels May 10, 2024
@alamb alamb added the api change Changes the API exposed to users of the crate label May 10, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lewiszlw 🙏 -- this looks like a nice change to me

Copy link
Contributor

@yyy1000 yyy1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, from #8258 (comment) it seems that Name in all kinds of function are not used yet.

@comphead comphead merged commit 6d413a4 into apache:main May 11, 2024
23 checks passed
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change Changes the API exposed to users of the crate core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules substrait
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants