Implement min/max for interval types #11015
Conversation
|
Thanks @maxburke for taking this! Could you also implement for the remaining two interval types? Except |
There was a problem hiding this comment.
Thank you @maxburke and @waynexia
I also think this PR needs some tests; I wrote some for your consideration here urbanlogiq#91 (which also cover the three interval types)
|
Marking as draft while feedback is addressed (I a trying to work through the review queue) |
maxburke
force-pushed
the
interval-min-max
branch
from
aa490eb
to
a879c54
Compare
|
@alamb merged; and feedback addressed |
| # aggregate_decimal_min | ||
| query RT | ||
| select min(c1), arrow_typeof(min(c1)) from d_table | ||
| # aggregate Interval(MonthDayNano) min/max |
There was a problem hiding this comment.
I think these tests needs to be updated now that you have implemented the correct logic
You can do so by running
cargo test --test sqllogictests -- aggregate --completeAnd then verifying and checking in the results
There was a problem hiding this comment.
updated; I think they look right at a glance, but I'm not well versed in this part of the system. can you verify?
There was a problem hiding this comment.
They looked good to me -- thanks!
* Implement min/max for interval types * Add sqllogictests for min/max intervals * Add tests for interval min/max * update sql logic tests --------- Co-authored-by: Andrew Lamb <[email protected]>
Closes #11014