adding config to control Varchar behavior #11090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Looks good to me -- thank you @Lordworms
I had a suggestion for a different parameter name, but I don't think that is required
datafusion/common/src/config.rs
Outdated
| /// type with a specified length. This can be useful for enforcing certain schema | ||
| /// constraints or maintaining compatibility with systems that do not support | ||
| /// length-specified `Varchar` types. | ||
| pub error_on_varchar_with_length: bool, default = false |
There was a problem hiding this comment.
It might be easier to understand to avoid the double negative here
So perhaps the config flag could be support_varchar_with_length and default to true 🤔
There was a problem hiding this comment.
sure, I'll fix it
alamb
reviewed
Jun 28, 2024
There was a problem hiding this comment.
Thanks again @Lordworms
I tweaked the config documentation a little and added a new test.
This looks great
comphead
pushed a commit
to comphead/arrow-datafusion
that referenced
this pull request
Jul 2, 2024
* adding config to control Varchar behavior * fix failed tests * fix config_md * format md * optimize code * format md * format md * adding config * Tweak documentation * Update sqllogictest * tweaks strings --------- Co-authored-by: Andrew Lamb <[email protected]>
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* adding config to control Varchar behavior * fix failed tests * fix config_md * format md * optimize code * format md * format md * adding config * Tweak documentation * Update sqllogictest * tweaks strings --------- Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10743
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?