-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support filter for List #11091
Support filter for List #11091
Conversation
It seems we need to rewrite The purpose is to remove these two lines, which tries to convert non-list to list, which is not expected. But it is incorrectly used for datafusion/datafusion/expr/src/type_coercion/binary.rs Lines 957 to 958 in c7ac8b8
|
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jayzhan211 -- this looks very good to me 👨🍳 👌
Really nice
return Ok(BooleanArray::new_null(len)); | ||
} | ||
|
||
let cmp = make_comparator(l, r, SortOptions::default())?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it worth a comment here explaining the choice of NULL comparison / sorting?
Signed-off-by: jayzhan211 <[email protected]>
🚀 |
* support basic list cmp Signed-off-by: jayzhan211 <[email protected]> * add more ops Signed-off-by: jayzhan211 <[email protected]> * add distinct Signed-off-by: jayzhan211 <[email protected]> * nested Signed-off-by: jayzhan211 <[email protected]> * add comment Signed-off-by: jayzhan211 <[email protected]> --------- Signed-off-by: jayzhan211 <[email protected]>
Which issue does this PR close?
Close #9857
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?