Minor Fix for Logical and Physical Expr Conversions #11142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Looks like a nice cleanup to me -- thank you @berkaysynnada
| @@ -867,13 +868,6 @@ mod test { | |||
| LiteralGuarantee::try_new(column, Guarantee::NotIn, literals.iter()).unwrap() | |||
| } | |||
|
|
|||
| /// Convert a logical expression to a physical expression (without any simplification, etc) | |||
| fn logical2physical(expr: &Expr, schema: &Schema) -> Arc<dyn PhysicalExpr> { | |||
There was a problem hiding this comment.
I was going to suggest using SessonState::create_physical_expr or SessionContext::create_physical_expr but I think that those are not available to code in the physical-expr crate
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Minor * Update planner.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This is just a minor clean-up PR, locating
logical2physical()where other physical expressions are created. I have also added a notice for the recently added API.What changes are included in this PR?
Removes some duplications of a function and add a notice for
with_new_expressions()API.Are these changes tested?
Are there any user-facing changes?