Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable clone_on_ref_ptr clippy lint on physical-plan crate #11241

Merged

Conversation

lewiszlw
Copy link
Member

@lewiszlw lewiszlw commented Jul 3, 2024

Which issue does this PR close?

part of #11143.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @lewiszlw 🙏

@alamb
Copy link
Contributor

alamb commented Jul 5, 2024

Per #11240 (comment) on #11240 let's plan on merging this one next week

@alamb alamb merged commit 37428bb into apache:main Jul 8, 2024
23 checks passed
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
…11241)

* Enable clone_on_ref_ptr clippy lint on physical-plan crate

* fmt

* Update for clippy

* Update new clippy

---------

Co-authored-by: Andrew Lamb <[email protected]>
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jul 18, 2024
…11241)

* Enable clone_on_ref_ptr clippy lint on physical-plan crate

* fmt

* Update for clippy

* Update new clippy

---------

Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants