minor: format Expr::get_type()
#11267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgao
commented
Jul 4, 2024
| @@ -237,7 +237,11 @@ impl ExprSchemable for Expr { | |||
| Expr::Like { .. } | Expr::SimilarTo { .. } => Ok(DataType::Boolean), | |||
| Expr::Placeholder(Placeholder { data_type, .. }) => { | |||
| data_type.clone().ok_or_else(|| { | |||
| plan_datafusion_err!("Placeholder type could not be resolved. Make sure that the placeholder is bound to a concrete type, e.g. by providing parameter values.") | |||
| plan_datafusion_err!( | |||
There was a problem hiding this comment.
This is the actual change; the others are made by cargo fmt.
alamb
approved these changes
Jul 5, 2024
comphead
pushed a commit
to comphead/arrow-datafusion
that referenced
this pull request
Jul 8, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
The follwoing overlong string literal prevents rustfmt from formatting the match arm in that function.
datafusion/datafusion/expr/src/expr_schema.rs
Line 240 in 6e63748
Related to rust-lang/rustfmt#3863
What changes are included in this PR?
Use multiple lines to replace the overly long string literal and make
cargo fmtwork.Even though we can use the format_strings option to do this automatically, it is unstable, and most IDEs do not enable it by default.
Are these changes tested?
Yes
Are there any user-facing changes?
No