-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: re-enable window function over parquet with forced collisions #11939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-ran the relevant test: cargo test --test sqllogictests --features=force_hash_collisions -- parquet And indeed it passes locally for me too
|
@@ -251,27 +251,25 @@ SELECT COUNT(*) FROM timestamp_with_tz; | |||
---- | |||
131072 | |||
|
|||
# FIXME(#TODO) fails with feature `force_hash_collisions` | |||
# https://github.com/apache/datafusion/issues/11660 | |||
# Perform the query: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Perform the query: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to add some comments why test is so specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree better comments would be nice -- however I don't think this PR makes the comment any more/less cryptic, so I don't think we should hold it for better comments.
Maybe we can improve the comments as a future PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -251,27 +251,25 @@ SELECT COUNT(*) FROM timestamp_with_tz; | |||
---- | |||
131072 | |||
|
|||
# FIXME(#TODO) fails with feature `force_hash_collisions` | |||
# https://github.com/apache/datafusion/issues/11660 | |||
# Perform the query: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree better comments would be nice -- however I don't think this PR makes the comment any more/less cryptic, so I don't think we should hold it for better comments.
Maybe we can improve the comments as a future PR
Which issue does this PR close?
Closes #11660.
Rationale for this change
After several attempts to reproduce the failure locally and in fork CI it still was not reproducing. Also I wasn't able to find any workflow failure related to 1.80 upgrade in PRs and on main. So, trying to just uncomment the test.
What changes are included in this PR?
Test uncommented.
Are these changes tested?
Are there any user-facing changes?