Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement native support StringView for substr_index #11974

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Aug 14, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

Part of #11752 and #11790

What changes are included in this PR?

Are these changes tested?

YES, with sqllogictests.

Are there any user-facing changes?

NO

@github-actions github-actions bot added sqllogictest SQL Logic Tests (.slt) functions labels Aug 14, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 -- very nice -- thank you @PsiACE

200w

@alamb alamb merged commit a00922b into apache:main Aug 14, 2024
24 checks passed
@PsiACE PsiACE deleted the substrindex branch August 15, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants