Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve StringView support for SUBSTR #12044

Merged
merged 27 commits into from
Sep 6, 2024
Merged

Improve StringView support for SUBSTR #12044

merged 27 commits into from
Sep 6, 2024
+245 −42

Commits on Aug 17, 2024

  1. operate stringview instead of generating string in SUBSTR

    @Kev1n8
    Kev1n8 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    44894e1 View commit details
    Browse the repository at this point in the history

  2. treat Utf8View as Text in sqllogictests output

    @Kev1n8
    Kev1n8 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    4810be9 View commit details
    Browse the repository at this point in the history

  3. add bench to see enhancement of utf8view against utf8 and large_utf8

    @Kev1n8
    Kev1n8 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    e8854b8 View commit details
    Browse the repository at this point in the history

  4. fix a tiny bug

    @Kev1n8
    Kev1n8 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    35e4658 View commit details
    Browse the repository at this point in the history

  5. make clippy happy

    @Kev1n8
    Kev1n8 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    bf6c37e View commit details
    Browse the repository at this point in the history

  6. add tests to cover stringview larger than 12B and correct the code

    @Kev1n8
    Kev1n8 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    74acc7c View commit details
    Browse the repository at this point in the history

  7. better comments

    @Kev1n8
    Kev1n8 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    af795a4 View commit details
    Browse the repository at this point in the history

  8. fix lint

    @Kev1n8
    Kev1n8 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    f8989d2 View commit details
    Browse the repository at this point in the history

  9. correct feature setting

    @Kev1n8
    Kev1n8 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    26a878a View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. avoid expensive utf8 and some other checks

    @Kev1n8
    Kev1n8 committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    2d8458e View commit details
    Browse the repository at this point in the history

  2. fix lint

    @Kev1n8
    Kev1n8 committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    934516a View commit details
    Browse the repository at this point in the history

  3. remove unnecessary indirection

    @Kev1n8
    Kev1n8 committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    48e1643 View commit details
    Browse the repository at this point in the history

  4. add optimized_utf8_to_str_type

    @Kev1n8
    Kev1n8 committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    6ff32fc View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Simplify type check

    @alamb
    alamb committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9537c47 View commit details
    Browse the repository at this point in the history

  2. Use ByteView

    @alamb
    alamb committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5356b27 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Merge pull request #1 from alamb/alamb/cleanup_substr 

    Alamb/cleanup substr
    @Kev1n8
    Kev1n8 authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    bef80cb View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Merge remote-tracking branch 'apache/main' into stringview-output-for… 

    …-substr
    @alamb
    alamb committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    118aaba View commit details
    Browse the repository at this point in the history

  2. update datafusion-cli.lock

    @alamb
    alamb committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    b4e1ac7 View commit details
    Browse the repository at this point in the history

  3. Remove duration override

    @alamb
    alamb committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    7106ef2 View commit details
    Browse the repository at this point in the history

  4. format toml

    @alamb
    alamb committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    28d6aca View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. refactor the code, using append_view_u128 from arrow

    @Kev1n8
    Kev1n8 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3be3553 View commit details
    Browse the repository at this point in the history

  2. manually collect the views and nulls

    @Kev1n8
    Kev1n8 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b288605 View commit details
    Browse the repository at this point in the history

  3. remove bench file and fix some comments

    @Kev1n8
    Kev1n8 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e2643f9 View commit details
    Browse the repository at this point in the history

  4. fix tiny mistake

    @Kev1n8
    Kev1n8 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    f462bbb View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Merge remote-tracking branch 'apache/main' into stringview-output-for… 

    …-substr
    @alamb
    alamb committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    12e878c View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Merge remote-tracking branch 'apache/main' into stringview-output-for… 

    …-substr
    @alamb
    alamb committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9320e41 View commit details
    Browse the repository at this point in the history

  2. Update Cargo.lock

    @alamb
    alamb committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    2c88a19 View commit details
    Browse the repository at this point in the history