Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for overflow in substring with negative start #12141

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Check for overflow in substring with negative start #12141

merged 1 commit into from
Aug 24, 2024
+37 −10

Conversation

findepi
Copy link
Member

@findepi findepi commented Aug 23, 2024

Fixes #12129

@findepi findepi force-pushed the findepi/check-for-overflow-in-substring-with-negative-start-2e8a41 branch from af158a1 to 5d54067 Compare August 23, 2024 20:12
@findepi
Copy link
Member Author

findepi commented Aug 24, 2024

cc @2010YOUY01

alamb
alamb approved these changes Aug 24, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @findepi (and @2010YOUY01 for finding it!)

@findepi
Copy link
Member Author

findepi commented Aug 24, 2024

and @2010YOUY01 for finding it!

i remain eternally impressed by this part.
#11030 is sooo awesome!

@comphead comphead merged commit 696ac49 into apache:main Aug 24, 2024
24 checks passed
@findepi findepi deleted the findepi/check-for-overflow-in-substring-with-negative-start-2e8a41 branch August 25, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in substring() scalar function (SQLancer)
3 participants
@findepi @alamb @comphead