Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of trim for string view (10%) #12395

Merged
merged 26 commits into from
Sep 25, 2024
Merged

Improve performance of trim for string view (10%) #12395

merged 26 commits into from
Sep 25, 2024
+605 −70

Commits on Sep 10, 2024

  1. draft.

    @Rachelint
    Rachelint committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    736eb11 View commit details
    Browse the repository at this point in the history

  2. add unit tests for xTrim.

    @Rachelint
    Rachelint committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a0da2d0 View commit details
    Browse the repository at this point in the history

  3. fix fmt.

    @Rachelint
    Rachelint committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3c8b035 View commit details
    Browse the repository at this point in the history

  4. tmp copy for ci.

    @Rachelint
    Rachelint committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    06d104d View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. move make_and_append_view to common.

    @Rachelint
    Rachelint committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    48cb4db View commit details
    Browse the repository at this point in the history

  2. fix sting view trim about the process of empty string.

    @Rachelint
    Rachelint committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    863e9b7 View commit details
    Browse the repository at this point in the history

  3. fix compile.

    @Rachelint
    Rachelint committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    36a8125 View commit details
    Browse the repository at this point in the history

  4. eliminate some repeated codes.

    @Rachelint
    Rachelint committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    aa2c131 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. add sql test case about string view trim.

    @Rachelint
    Rachelint committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e3e9b53 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into string-view-trim

    @Rachelint
    Rachelint committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    dbd0f25 View commit details
    Browse the repository at this point in the history

  3. remove unused imports.

    @Rachelint
    Rachelint committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6d5660f View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Merge branch 'main' into string-view-trim

    @Rachelint
    Rachelint committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    65ef988 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Merge branch 'main' into string-view-trim

    @Rachelint
    Rachelint committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    4129a43 View commit details
    Browse the repository at this point in the history

  2. fix tests.

    @Rachelint
    Rachelint committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    522c87f View commit details
    Browse the repository at this point in the history

  3. remove stale file.

    @Rachelint
    Rachelint committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    840ec46 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Merge remote-tracking branch 'apache/main' into string-view-trim

    @alamb
    alamb committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    307850a View commit details
    Browse the repository at this point in the history

  2. Avoid unecessary unsafe

    @alamb
    alamb committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    064450f View commit details
    Browse the repository at this point in the history

  3. add unit test cases with a unlined string view output.

    @Rachelint
    Rachelint committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c2510de View commit details
    Browse the repository at this point in the history

  4. fix tests.

    @Rachelint
    Rachelint committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    38790b2 View commit details
    Browse the repository at this point in the history

  5. improve comments.

    @Rachelint
    Rachelint committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    20197d9 View commit details
    Browse the repository at this point in the history

  6. add todo and the related issue.

    @Rachelint
    Rachelint committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2112bc5 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. use the safe way to get start_offset after trimming.

    @Rachelint
    Rachelint committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    790f7a9 View commit details
    Browse the repository at this point in the history

  2. fix comments.

    @Rachelint
    Rachelint committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f817462 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into string-view-trim

    @Rachelint
    Rachelint committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    148a991 View commit details
    Browse the repository at this point in the history

  4. Remove redundant test

    @alamb
    alamb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f9c1543 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'apache/main' into string-view-trim

    @alamb
    alamb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e39f916 View commit details
    Browse the repository at this point in the history