Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordsmith project description #12778

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Conversation

matthewmturner
Copy link
Contributor

@matthewmturner matthewmturner commented Oct 6, 2024

Which issue does this PR close?

Closes #.

Follow on to #12666

Rationale for this change

Improve project description to make it clear there are first class projects targeting end users.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 6, 2024
@matthewmturner
Copy link
Contributor Author

@alamb FYI

@alamb alamb changed the title Update description Update project description Oct 7, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @matthewmturner -- I think this is an improvement 🙏

I have a suggestion for some additional improvements for your consideration

README.md Outdated Show resolved Hide resolved
Co-authored-by: Andrew Lamb <[email protected]>
README.md Outdated
The DataFusion project provides libraries and binaries for data system
developers and end users such as data engineers and analysts. This repository
contains libraries for system developers. The following related projects work
out of the box and target end users.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DataFrame API that this project ships, for whom it is? (mentioned 13 lines below)

Also, "The target audience for the DataFusion crates in this repository are developers" (9 lines below) sounds like a repetition now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DataFrame API that this project ships, for whom it is? (mentioned 13 lines below)

It is a good question -- I think @timsaucer and @Omega359 uses the Rust DataFrame library as is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do use the dataframe api almost exclusively. I say almost because I do allow sql expressions in my library which are converted to Expr's in DF and used via the dataframe api.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do use the DataFrame API exclusively, but I work almost entirely via datafusion-python.

@alamb alamb changed the title Update project description Wordsmith project description Oct 9, 2024
@alamb
Copy link
Contributor

alamb commented Oct 9, 2024

I took the liberty of incorporating @findepi 's comments and updating the main docs page too and pushing an update to this PR

Comment on lines +58 to +59
"Out of the box,"
DataFusion offers [SQL] and [`Dataframe`] APIs, excellent [performance],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Will this render with a linebreak after "Out of the box,"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe it will. Markdown is a bit ambiguous on this and different impl's handle this differently however most either will force a newline in rendered view if the line ends with two spaces (now that is a horrible pattern) or a back slash. This comment editor is an example of something that does put text on a newline
when a line break is encountered.

@alamb
Copy link
Contributor

alamb commented Oct 11, 2024

🚀

@alamb alamb merged commit 576da1d into apache:main Oct 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants