Remove unused dependencies and features #12808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
approved these changes
Oct 8, 2024
| @@ -69,6 +68,7 @@ rand = { workspace = true } | |||
| tokio = { workspace = true } | |||
|
|
|||
| [dev-dependencies] | |||
| datafusion-functions-aggregate = { workspace = true } | |||
There was a problem hiding this comment.
👍 nice
As a follow on it would be great to remove this dependency too, but having it as a dev dependency is clearly better than a real dependency in my mind
There was a problem hiding this comment.
Some tests require an aggregate function and will check the aggregation results, so not sure if it's possible to remove this dependency 🤔.
There was a problem hiding this comment.
Maybe we can move that test into the sql_integration binary or something
There was a problem hiding this comment.
I found that some tests call private methods, which means we can't move them to a different package. Perhaps we can try to address this in a subsequent PR.
findepi
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Found by cargo-udeps. There are some unused dependencies in Cargo.toml
The
regex_expressionsandencoding_expressionsfeature originate from thedatafusion-functionspackage.The
datafusion-physical-exprpackage doesn’t depend ondatafusion-functions, so I think it should not incorporate these two features.What changes are included in this PR?
regex_expressionsandencoding_expressionsfeature fromdatafusion-physical-exprAre these changes tested?
Yes
Are there any user-facing changes?
No