Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement special GroupColumn support for byte view #12809

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Implement special GroupColumn support for byte view #12809

wants to merge 26 commits into from

Commits on Oct 8, 2024

  1. define ByteGroupValueViewBuilder.

    @Rachelint
    Rachelint committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ca033e0 View commit details
    Browse the repository at this point in the history

  2. impl append.

    @Rachelint
    Rachelint committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ffcc1a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. impl equal to.

    @Rachelint
    Rachelint committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4842965 View commit details
    Browse the repository at this point in the history

  2. fix compile.

    @Rachelint
    Rachelint committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    66bb7be View commit details
    Browse the repository at this point in the history

  3. fix comments.

    @Rachelint
    Rachelint committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ef1efce View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. impl take_n.

    @Rachelint
    Rachelint committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    152a8b1 View commit details
    Browse the repository at this point in the history

  2. impl build.

    @Rachelint
    Rachelint committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d61c3ec View commit details
    Browse the repository at this point in the history

  3. impl rest functions in GroupColumn.

    @Rachelint
    Rachelint committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    151377e View commit details
    Browse the repository at this point in the history

  4. fix output when panic.

    @Rachelint
    Rachelint committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    63e11cb View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. add e2e sql tests.

    @Rachelint
    Rachelint committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    15d8349 View commit details
    Browse the repository at this point in the history

  2. add unit tests.

    @Rachelint
    Rachelint committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    d9ee724 View commit details
    Browse the repository at this point in the history

  3. switch to a really elegant style codes from alamb.

    @Rachelint
    Rachelint committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    beffa35 View commit details
    Browse the repository at this point in the history

  4. fix take_n.

    @Rachelint
    Rachelint committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    46822f9 View commit details
    Browse the repository at this point in the history

  5. improve comments.

    @Rachelint
    Rachelint committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    3a93584 View commit details
    Browse the repository at this point in the history

  6. fix compile.

    @Rachelint
    Rachelint committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    f99f55c View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. fix clippy.

    @Rachelint
    Rachelint committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    37b4816 View commit details
    Browse the repository at this point in the history

  2. define more testcases in test_byte_view_take_n.

    @Rachelint
    Rachelint committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    d78c68d View commit details
    Browse the repository at this point in the history

  3. connect up.

    @Rachelint
    Rachelint committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    7cb7dfc View commit details
    Browse the repository at this point in the history

  4. fix doc.

    @Rachelint
    Rachelint committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    e6c7e7e View commit details
    Browse the repository at this point in the history

  5. Do not re-validate output is utf8

    @alamb
    alamb committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    36d556e View commit details
    Browse the repository at this point in the history

  6. Merge pull request #1 from alamb/alamb/tweak-group 

    Do not re-validate output is utf8
    @Rachelint
    Rachelint authored Oct 13, 2024
    Configuration menu
    Copy the full SHA
    f76c376 View commit details
    Browse the repository at this point in the history

  7. switch to unchecked when building array.

    @Rachelint
    Rachelint committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    1fd926f View commit details
    Browse the repository at this point in the history

  8. improve naming.

    @Rachelint
    Rachelint committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    34918cb View commit details
    Browse the repository at this point in the history

  9. use let else to make the codes clearer.

    @Rachelint
    Rachelint committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    8348024 View commit details
    Browse the repository at this point in the history

  10. fix typo.

    @Rachelint
    Rachelint committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    023ed64 View commit details
    Browse the repository at this point in the history

  11. improve unit test coverage for ByteViewGroupValueBuilder.

    @Rachelint
    Rachelint committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    c4d45c7 View commit details
    Browse the repository at this point in the history