Update documentation example for change in API #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Feb 15, 2022
xudong963
approved these changes
Feb 16, 2022
| @@ -28,18 +37,18 @@ use datafusion::prelude::*; | |||
| async fn main() -> datafusion::error::Result<()> { | |||
| // register the table | |||
| let mut ctx = ExecutionContext::new(); | |||
| ctx.register_csv("example", "tests/example.csv", CsvReadOptions::new())?; | |||
| ctx.register_csv("example", "tests/example.csv", CsvReadOptions::new()).await?; | |||
There was a problem hiding this comment.
Amazing! unexpectedly, no .await before.
Co-authored-by: xudong.w <[email protected]>
|
Thanks for the review @xudong963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #1587
I noticed the examples don't work anymore when testing out the latest datafusion release. 🤦
Rationale for this change
The example (published at https://arrow.apache.org/datafusion/user-guide/example-usage.html) is the first thing users will likely try
What changes are included in this PR?
Update the example so it will run with changes to make more methods
asyncAre there any user-facing changes?
Just docs